[PATCH 1/4] winegstreamer: Wake up the read thread when wg_parser_connect fails.

Derek Lesho dlesho at codeweavers.com
Wed Sep 15 15:09:34 CDT 2021


This bug causes read_thread never to shut down when wg_parser_connect fails, which we rely on in the next commit.

Signed-off-by: Derek Lesho <dlesho at codeweavers.com>
---
 dlls/winegstreamer/wg_parser.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/winegstreamer/wg_parser.c b/dlls/winegstreamer/wg_parser.c
index cd12a23d0c8..2e409f5ae18 100644
--- a/dlls/winegstreamer/wg_parser.c
+++ b/dlls/winegstreamer/wg_parser.c
@@ -1518,7 +1518,11 @@ static HRESULT CDECL wg_parser_connect(struct wg_parser *parser, uint64_t file_s
     parser->next_pull_offset = 0;
 
     if (!parser->init_gst(parser))
+    {
+        parser->sink_connected = false;
+        pthread_cond_signal(&parser->read_cond);
         return E_FAIL;
+    }
 
     pthread_mutex_lock(&parser->mutex);
 
@@ -1559,6 +1563,8 @@ static HRESULT CDECL wg_parser_connect(struct wg_parser *parser, uint64_t file_s
             if (parser->error)
             {
                 pthread_mutex_unlock(&parser->mutex);
+                parser->sink_connected = false;
+                pthread_cond_signal(&parser->read_cond);
                 return E_FAIL;
             }
             if (gst_pad_query_duration(stream->their_src, GST_FORMAT_TIME, &duration))
-- 
2.33.0




More information about the wine-devel mailing list