[PATCH 3/3] winegstreamer: Merge parser creation functions and wg_parser_connect.

[Zebediah Figura]

On 9/16/21 4:00 PM, Derek Lesho wrote:
> Signed-off-by: Derek Lesho <dlesho at codeweavers.com>
> ---
>   dlls/winegstreamer/gst_private.h   |  17 +-
>   dlls/winegstreamer/media_source.c  |  11 +-
>   dlls/winegstreamer/quartz_parser.c |  40 +--
>   dlls/winegstreamer/wg_parser.c     | 405 ++++++++++++++---------------
>   4 files changed, 238 insertions(+), 235 deletions(-)
> 

This patch does an awful lot of things at once, e.g.:

(1) waiting for initialization in some other functions instead of in 
wg_parser_connect()

(2) waiting for duration in wg_parser_stream_get_duration()

(3) merging the separate wg_*_parser_create() functions together

(4) merging create with connect

Can it be split up?

It would also be nice to have a decent explanation for (1). I know we 
discussed this in private, but that kind of thing should show up in the 
patch itself as well. It's also not clear to me how much we need to have 
initialized, and when, for push-mode clients; that kind of context would 
be pretty helpful when reviewing.