[PATCH vkd3d 01/10] vkd3d: Use minimum width/height/layer framebuffer.
Conor McCarthy
cmccarthy at codeweavers.com
Fri Sep 17 10:36:59 CDT 2021
All attachments must be at least as large as the framebuffer; using a
max operator is not compliant with Vulkan
(VUID-VkFramebufferCreateInfo-flags-04533, etc).
From: Hans-Kristian Arntzen <post at arntzen-software.no>
Signed-off-by: Conor McCarthy <cmccarthy at codeweavers.com>
---
libs/vkd3d/command.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c
index 9f4a4149..e81feea4 100644
--- a/libs/vkd3d/command.c
+++ b/libs/vkd3d/command.c
@@ -4517,6 +4517,7 @@ static void STDMETHODCALLTYPE d3d12_command_list_OMSetRenderTargets(ID3D12Graphi
BOOL single_descriptor_handle, const D3D12_CPU_DESCRIPTOR_HANDLE *depth_stencil_descriptor)
{
struct d3d12_command_list *list = impl_from_ID3D12GraphicsCommandList2(iface);
+ const VkPhysicalDeviceLimits *limits = &list->device->vk_info.device_limits;
const struct d3d12_rtv_desc *rtv_desc;
const struct d3d12_dsv_desc *dsv_desc;
VkFormat prev_dsv_format;
@@ -4535,9 +4536,9 @@ static void STDMETHODCALLTYPE d3d12_command_list_OMSetRenderTargets(ID3D12Graphi
render_target_descriptor_count = ARRAY_SIZE(list->rtvs);
}
- list->fb_width = 0;
- list->fb_height = 0;
- list->fb_layer_count = 0;
+ list->fb_width = limits->maxFramebufferWidth;
+ list->fb_height = limits->maxFramebufferHeight;
+ list->fb_layer_count = limits->maxFramebufferLayers;
for (i = 0; i < render_target_descriptor_count; ++i)
{
if (single_descriptor_handle)
@@ -4567,9 +4568,9 @@ static void STDMETHODCALLTYPE d3d12_command_list_OMSetRenderTargets(ID3D12Graphi
}
list->rtvs[i] = view->u.vk_image_view;
- list->fb_width = max(list->fb_width, rtv_desc->width);
- list->fb_height = max(list->fb_height, rtv_desc->height);
- list->fb_layer_count = max(list->fb_layer_count, rtv_desc->layer_count);
+ list->fb_width = min(list->fb_width, rtv_desc->width);
+ list->fb_height = min(list->fb_height, rtv_desc->height);
+ list->fb_layer_count = min(list->fb_layer_count, rtv_desc->layer_count);
}
prev_dsv_format = list->dsv_format;
@@ -4591,9 +4592,9 @@ static void STDMETHODCALLTYPE d3d12_command_list_OMSetRenderTargets(ID3D12Graphi
}
list->dsv = view->u.vk_image_view;
- list->fb_width = max(list->fb_width, dsv_desc->width);
- list->fb_height = max(list->fb_height, dsv_desc->height);
- list->fb_layer_count = max(list->fb_layer_count, dsv_desc->layer_count);
+ list->fb_width = min(list->fb_width, dsv_desc->width);
+ list->fb_height = min(list->fb_height, dsv_desc->height);
+ list->fb_layer_count = min(list->fb_layer_count, dsv_desc->layer_count);
list->dsv_format = dsv_desc->format->vk_format;
}
else
--
2.32.0
More information about the wine-devel
mailing list