[PATCH v4 1/4] user32/tests: Fix occasional test failure in test_ShowWindow().

Connor McAdams cmcadams at codeweavers.com
Fri Sep 17 10:41:14 CDT 2021


Windows 8+ sometimes sends an optional WM_WINDOWPOSCHANGED after an optional
WM_WINDOWPOSCHANGING.

Signed-off-by: Connor McAdams <cmcadams at codeweavers.com>
---
-v4: Add fix for test_ShowWindow() failure, and remove
 test_mdi_messages() patches to shrink patch set for easier review.

 dlls/user32/tests/msg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 4c9f1dc6913..f2bfb81679f 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -13389,9 +13389,10 @@ static const struct message WmShowNoActivate_2[] = {
     { HCBT_ACTIVATE, hook|optional },
     { EVENT_SYSTEM_FOREGROUND, winevent_hook|wparam|lparam|optional, 0, 0 }, /* Win7 sends this. */
     { WM_WINDOWPOSCHANGING, sent|wparam|optional, SWP_NOSIZE|SWP_NOMOVE },
+    { WM_WINDOWPOSCHANGED, sent|optional }, /* Sometimes sent on Win8+. */
     { HCBT_SETFOCUS, hook|optional },
     { EVENT_OBJECT_FOCUS, winevent_hook|wparam|lparam|optional, OBJID_CLIENT, 0 }, /* Win7 sends this. */
-    { WM_WINDOWPOSCHANGED, sent|wparam, SWP_SHOWWINDOW|SWP_NOACTIVATE|SWP_FRAMECHANGED|SWP_NOCOPYBITS|SWP_STATECHANGED, 0, SWP_NOACTIVATE },
+    { WM_WINDOWPOSCHANGED, sent|wparam|optional, SWP_SHOWWINDOW|SWP_NOACTIVATE|SWP_FRAMECHANGED|SWP_NOCOPYBITS|SWP_STATECHANGED, 0, SWP_NOACTIVATE },
     { WM_MOVE, sent|defwinproc },
     { WM_SIZE, sent|wparam|defwinproc, SIZE_RESTORED },
     { HCBT_SETFOCUS, hook|optional },
-- 
2.25.1




More information about the wine-devel mailing list