[PATCH v4 1/6] robocopy: Add stub

Hugh McMaster hugh.mcmaster at outlook.com
Mon Sep 20 06:39:24 CDT 2021


Hi Florian,

On Sat, 18 Sept 2021 at 17:48, Florian Eder wrote:
>
> Basic files and required changes to configure(.ac) to create a stub version
> of the robocopy utility
>
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43653
> Signed-off-by: Florian Eder <others.meder at gmail.com>
> ---

Adding a stub isn't going to fix that bug. You'll need to implement a
lot of functionality before thinking about closing the bug.

[snip]

> diff --git a/programs/robocopy/main.c b/programs/robocopy/main.c
> new file mode 100644
> index 00000000000..00dacc8ab6c
> --- /dev/null
> +++ b/programs/robocopy/main.c
> @@ -0,0 +1,29 @@
> +/*
> + * Copyright 2021 Florian Eder
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> + */
> +
> +#include "wine/debug.h"
> +WINE_DEFAULT_DEBUG_CHANNEL(robocopy);
> +
> +#define WIN32_LEAN_AND_MEAN
> +#include <windows.h>
> +
> +int __cdecl wmain(int argc, WCHAR *argv[])
> +{
> +    WINE_FIXME("robocopy stub");
> +    return 0;
> +}

In general, stubs should return non-zero to indicate failure.



More information about the wine-devel mailing list