[PATCH] msxml3/tests: Avoid double-free using BSTR helper.

Daniel Lehman dlehman25 at gmail.com
Mon Sep 20 10:44:01 CDT 2021


Signed-off-by: Daniel Lehman <dlehman25 at gmail.com>
---
same pattern as 001aa01760168cd7e21e70bc1bb5fcc39a8432c3
although they don't cause any crashes for me
---
 dlls/msxml3/tests/domdoc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 9e9789ebd9a..a86c0b08d6b 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -5267,7 +5267,6 @@ static void test_cloneNode(void )
     V_VT(&v) = VT_BSTR;
     hr = IXMLDOMDocument2_setProperty(doc, _bstr_("SelectionLanguage"), v);
     ok(hr == S_OK, "got 0x%08x\n", hr);
-    VariantClear(&v);
 
     /* clone document node */
     hr = IXMLDOMDocument2_cloneNode(doc, VARIANT_TRUE, &node);
@@ -8767,7 +8766,6 @@ static void test_put_nodeTypedValue(void)
     V_BSTR(&value) = _bstr_("1");
     hr = IXMLDOMElement_put_nodeTypedValue(elem, value);
     EXPECT_HR(hr, S_OK);
-    VariantClear(&value);
 
     V_VT(&value) = VT_EMPTY;
     hr = IXMLDOMElement_get_nodeTypedValue(elem, &value);
-- 
2.25.1




More information about the wine-devel mailing list