[PATCH 02/11] mshtml: Implement IHTMLElement::toString.

Jacek Caban jacek at codeweavers.com
Mon Sep 20 15:36:43 CDT 2021


Hi Gabriel,

On 9/20/21 4:46 PM, Gabriel Ivăncescu wrote:
> +        memcpy(tmp, prefix, sizeof(prefix));
> +        p = tmp + ARRAY_SIZE(prefix);
> +        if(*str) {
> +            *p++ = *str++;  /* copy first uppercase char */
> +            while(*str)
> +                *p++ = tolower(*str++);
> +        }
> +        memcpy(p, suffix, sizeof(suffix));


This is very fragile, it would use "HTMLIframeElement" for example. We 
could probably store a name of the object in dispex_static_data_t.


Thanks,

Jacek




More information about the wine-devel mailing list