[PATCH 1/6] winebus.sys: Remove the bogus SDL "unknown" HID report constant.
Rémi Bernon
rbernon at codeweavers.com
Tue Sep 21 01:36:39 CDT 2021
It was used for XInput compatibility and is not needed anymore.
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
dlls/winebus.sys/bus_sdl.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c
index b7734b4016e..bf36830b817 100644
--- a/dlls/winebus.sys/bus_sdl.c
+++ b/dlls/winebus.sys/bus_sdl.c
@@ -424,8 +424,7 @@ static NTSTATUS build_mapped_report_descriptor(struct platform_private *ext)
ext->hat_bit_offs = CONTROLLER_NUM_BUTTONS;
ext->buffer_length = (BUTTON_BIT_COUNT + 7) / 8
- + CONTROLLER_NUM_AXES * sizeof(WORD)
- + 2/* unknown constant*/;
+ + CONTROLLER_NUM_AXES * sizeof(WORD);
TRACE("Report will be %i bytes\n", ext->buffer_length);
@@ -457,10 +456,6 @@ static NTSTATUS build_mapped_report_descriptor(struct platform_private *ext)
return STATUS_NO_MEMORY;
}
- /* unknown constant */
- if (!hid_descriptor_add_padding(&ext->desc, 16))
- return STATUS_NO_MEMORY;
-
if (!descriptor_add_haptic(ext))
return STATUS_NO_MEMORY;
@@ -475,10 +470,6 @@ static NTSTATUS build_mapped_report_descriptor(struct platform_private *ext)
set_hat_value(ext, 0, compose_dpad_value(ext->sdl_controller));
- /* unknown constant */
- ext->report_buffer[14] = 0x89;
- ext->report_buffer[15] = 0xc5;
-
return STATUS_SUCCESS;
failed:
--
2.33.0
More information about the wine-devel
mailing list