[PATCH v4 8/8] oleacc: Add tests for default edit accessible object.
Piotr Caban
piotr.caban at gmail.com
Mon Sep 27 10:37:08 CDT 2021
On 9/27/21 4:44 PM, Connor McAdams wrote:
> In general, do you think this style of test is too complicated? I did it
> in hopes of making future tests for different control objects
> cleaner/more readable, but if really long test functions are preferable,
> I can do it that way. My main issue with doing long function body tests
> is that after awhile I find it hard to keep track of what is being
> tested.
I'm OK with this style of test. I'm not sure why you've got an
impression that there's anything wrong with the way the tests are
written. The only problem is that you're adding code that is not needed
at this point. It would be better to add more fields to test structure
when needed. There's nothing wrong in modifying the code when adding
tests for other classes.
Thanks,
Piotr
More information about the wine-devel
mailing list