[PATCH] configure.ac: don't use -Wmisleading-indentation compiler option (GCC11)
Zebediah Figura
zfigura at codeweavers.com
Mon Sep 27 12:30:33 CDT 2021
On 9/27/21 12:27 PM, Eric Pouech wrote:
> I'm not 100% sure about the right fix:
> - disable the warning altogether (that's what this patch does), but we
> won't report other *real* indentation errors. To be frank, I haven't
> looked at the hundred of lines of warnings to check if one pops up.
> - reformat the code in tests. note that
> todo_wine {
> ok(tst, "...");
> }
> or
> todo_wine ok(tst, "...");
> or
> todo_wine
> ok(tst, "...");
> don't generate warnings. but first one defeats the one liner, and the
> second and third ones don't preserve the line of the test unchanged
> when the todo is resolved
Personally I think that's a good thing; that allows you to use git-blame
to find out which commit fixed an ok() message, if any.
More information about the wine-devel
mailing list