[PATCH 5/6] configure: allow picking up a dedicated dwarf version from command line

[Eric Pouech]

Le 28/09/2021 à 16:04, Jacek Caban a écrit :
> Hi Eric,
>
> On 9/28/21 3:44 PM, Eric Pouech wrote:
>> @@ -2040,9 +2044,10 @@ char*f(const char *h,char n) {return 
>> strchr(h,n);}]])],[ac_cv_c_logicalop_noisy=
>>     esac
>>       dnl Default to dwarf-2 debug info
>> +  AC_SUBST(DEBUGFORMAT)
>>     for ac_flag in $CFLAGS; do
>>       case $ac_flag in
>> -      -g) WINE_TRY_CFLAGS([-gdwarf-2])
>> +      -g) WINE_TRY_CFLAGS([-g${DEBUGFORMAT:-dwarf-2}])
>>             WINE_TRY_CFLAGS([-gstrict-dwarf]) ;;
>>       esac
>>     done
>
>
> Maybe we could make it a bit smarter, by scanning CFLAGS for explicit 
> -gdwarf-X like CROSSDEBUG does. That should in fact make exposing 
> DEBUGFORMAT redundant. In case of CROSSDEBUG, we also have split debug 
> option that somehow needs to be passed to configure, but we don't have 
> that for native parts. (Still, DEBUGFORMAT may be useful for 
> convenience).
>
>
> Thanks,
>
> Jacek
>
>
Hi Jacek,

yes, that would be more coherent


going this path of coherency, would also require to have consistent 
naming between CROSSDEBUG and DEBUGFORMAT

I found the simple DEBUG a bit misleading, hence the DEBUGFORMAT choice

so renaming CROSSDEBUG into CROSSDEBUGFORMAT (or supporting both 
CROSSDEBUG and CROSSDEBUGFORMAT for easing the transition) would be even 
cleaner IMO

I'll resend along those lines

A+
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210928/142b4dc8/attachment-0001.htm>