[tools] testbot/cgi: Remove a stray single quote from textarea fields.
Francois Gouget
fgouget at codeweavers.com
Fri Apr 1 10:09:51 CDT 2022
It would set the default value of textareas to a single quote.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
This has been lurking from the start!
The change from checking whether $Value is true to whether it is
defined revealed this bug in the Register form which is the only one
to both have a textarea field and to provide a default value,
specifically an empty string (false).
---
testbot/lib/ObjectModel/CGI/FormPage.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm
index 9ce9fa93b..dfcd55e12 100644
--- a/testbot/lib/ObjectModel/CGI/FormPage.pm
+++ b/testbot/lib/ObjectModel/CGI/FormPage.pm
@@ -300,10 +300,7 @@ sub GenerateField($$$)
print "50' rows='", int(($MaxLength + 49) / 50);
}
print "'>";
- if (defined $Value)
- {
- print $self->escapeHTML($Value), "'";
- }
+ print $self->escapeHTML($Value) if (defined $Value);
print "</textarea>";
$self->GenerateRequired($PropertyDescriptor);
}
--
2.30.2
More information about the wine-devel
mailing list