[PATCH v2 2/3] kernel32/tests: Merge GlobalMemoryStatus(Ex) tests together.

Rémi Bernon rbernon at codeweavers.com
Tue Apr 5 03:43:04 CDT 2022


On 4/5/22 00:01, Francois Gouget wrote:
> On Fri, 25 Mar 2022, Rémi Bernon wrote:
> [...]
>> -    size = min(memex.ullTotalPhys, ~(SIZE_T)0 >> 1);
>> -    size_broken = min(memex.ullTotalPhys, ~(SIZE_T)0);
>> -    ok(compare_ulong64(mem.dwTotalPhys, size, max_diff)
>> -            || broken(compare_ulong64(mem.dwTotalPhys, size_broken, max_diff)) /* Win <= 8.1 with RAM size > 4GB */,
> 
> You've lost this broken() case in a couple of places which causes the
> tests to fail on the cw-gtx560 and cw-rx460 machines. That's because
> they have 16 GB of memory (> 4 GB) and in that case Windows 8.1 (<= Win
> <= 8.1) returns -1 (~(SIZE_T)0).
> 
> https://test.winehq.org/data/patterns.html#kernel32:heap
> 

Thanks! I believe I actually tried a local Win8.1 VM with > 4GB and 
didn't get the same results, so I thought it was an old broken result. 
I'll add it back.

-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list