[PATCH 1/6] kernel32/tests: Add console reallocation tests.

Jacek Caban jacek at codeweavers.com
Tue Apr 5 07:39:57 CDT 2022


Hi Torge,

On 4/5/22 04:06, Torge Matthies wrote:
> Signed-off-by: Torge Matthies<openglfreak at googlemail.com>
> ---
>   dlls/kernel32/tests/console.c | 46 +++++++++++++++++++++++++++++++++--
>   1 file changed, 44 insertions(+), 2 deletions(-)


It looks like both you and Eric tackled the problem. While duplication 
is suboptimal, it's definitely better than no one looking at this :) 
Eric's tests seemed more complete, so I signed off his version. Please 
take a look at them and eventually extend them if you see the need.


For the implementation itself, I think that using ConsoleHandle would be 
a bit nicer. See my other mail.


Thanks,

Jacek




More information about the wine-devel mailing list