[PATCH] wusa: Reimplement lookup_expression.

Hans Leidekker hans at codeweavers.com
Wed Apr 6 02:59:24 CDT 2022


On Tue, 2022-04-05 at 22:49 -0400, Mohamad Al-Jaf wrote:
> On Tue, Apr 5, 2022 at 11:26 AM Hans Leidekker <hans at codeweavers.com> wrote:
> > I saw you added 'wow64' as a synonym for 'x86'. Do you have an installer that
> > needs this? In any case, this should go in a separate patch.
> 
> Yeah, it's the same update package that had the unsupported
> expressions, Microsoft-Windows-MediaFeaturePack-OOB-Package_x64.msu. I
> can submit a separate patch for the wow64 architecture, but I'm not
> sure how to support it. Do I just add an extra or case in the existing
> if statements or is there a better way? Maybe assigning the assembly
> identity architecture to x86 if it's wow64, but this feels dirty. This
> expression table would solve that issue while keeping the code clean.
> What do you think?

You could add an is_x86() helper that returns true if the assembly architecture
matches "x86" or "wow64".





More information about the wine-devel mailing list