[PATCH v3 1/4] dwrite/tests: Add some tests for Segoe UI font family.

[Nikolay Sivov]

On 4/5/22 16:27, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov at codeweavers.com> wrote:
>
>>>> All this does is checking if font is installed, and we know it is
>>>> installed on all current Windows versions, it's not some directwrite
>>>> functionality. Second patch will already trigger a todo case when font
>>>> is installed in Wine.
>>> Thanks for the review.
>>>
>>> Intent of the test is to verify that "Segoe UI" font family doesn't include
>>> "Segoe UI Symbol", i.e. it makes sure that the suffix "Symbol" is not part
>>> of other ligitimate ones like "Regular", "Bold" or "Italic". Do you think
>>> that's not relevant or essential for testing?
>>>
>> The test for MapCharacters() in the second patch is using
>> GetFamilyNames() on returned instance, that's enough to tell that such
>> family exists.
>>
>> For special suffixes and synthesized names, the lists we are using are
>> exhaustive in terms of WPF font model. It's possible it changed since
>> then of course, but to see the full picture it's necessary to dump all
>> families groupings for default collection, and compare with what we have
>> on same set of fonts.
> Thanks, that makes sense. Basically, once I saw "Segoe UI"/"Segoe UI Symbol"
> mixup in the logs of the application that I'm working on, I wanted to make
> sure that "Symbol" suffix doesn't mean using some specific charmap in the font,
> and somehow explain missing 0x25d4 glyph.

I think for newer fonts that abandoned this idea, but MS symbol charmap 
is of course still supported.
This is reflected by IsSymbol() method.

>
> What do you think of remaining patches in the series? Should I rebase and
> resend them once the signed off patch is committed?
>
No need to rebase right now. I think main question is whether we want a 
new font or not, and it's not up to me to decide on that.