[PATCH v2 1/2] riched20/tests: Add tests for IRichEditOleCallback_QueryInsertObject.

[Huw Davies]

On Sat, Apr 02, 2022 at 01:26:43AM +0900, Jinoh Kang wrote:
> Signed-off-by: Jinoh Kang <jinoh.kang.kr at gmail.com>
> ---
> 
> Notes:
>     v1 -> v2:
>     - remove unused typedef storage class specifier from struct
>       IRichEditOleCallbackImpl definition (thanks huw)
>     - remove Hungarian notation from struct fields and callback params
>       (thanks huw)
> 
>  dlls/riched20/tests/richole.c | 247 ++++++++++++++++++++++++++++++++--
>  1 file changed, 236 insertions(+), 11 deletions(-)
> 
> diff --git a/dlls/riched20/tests/richole.c b/dlls/riched20/tests/richole.c
> index 24284a24484..fce4e74285d 100644
> --- a/dlls/riched20/tests/richole.c
> +++ b/dlls/riched20/tests/richole.c
> @@ -33,6 +33,169 @@
>  #include <tom.h>
>  #include <wine/test.h>
>  
> +#define EXPECT_TODO_WINE 0x80000000UL
> +
> +struct IRichEditOleCallbackImpl {

Let's put that brace on a new line.

> +    IRichEditOleCallback IRichEditOleCallback_iface;
> +    LONG ref;
> +    int line;
> +
> +    ULONG expect_queryinsertobject;
> +
> +    const CLSID *clsid;
> +    LPSTORAGE stg;

IStorage *

As already mentioned, there are many more LPXXXX below.

Also some of the lines are really long, let's get them below ~120
chars.  (Part of the issue is the "RichEditOleCallbackImpl_" prefix,
"re_ole_cb_" would be shorter).

Huw.