[PATCH 5/7] win32u: Partially move WM_SYSCOMMAND implementation from user32.

Thu Apr 7 09:34:06 CDT 2022

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=112161

Your paranoid android.

=== debian11 (32 bit report) ===

user32:
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
dialog.c:2144: Test failed: Unexpected window text "?ducome\winetest\tools\testbot\var\wine-win32\programs\winetest"
input.c:1315: Test failed: Wrong hook coords: (106 106) != (150,150)
input.c:1323: Test failed: GetCursorPos: (106,106)
input.c:1315: Test failed: Wrong hook coords: (106 106) != (150,150)
input.c:1323: Test failed: GetCursorPos: (106,106)
input.c:2182: Test failed: Unexpected rawinput data: 0
input.c:2162: Test failed: Unexpected rawinput data: -3
input.c:1628: Test failed: wrong position 5, expected 61x122 got 63x126
input.c:1628: Test failed: wrong position 9, expected 57x114 got 61x122
input.c:1628: Test failed: wrong position 11, expected 55x110 got 57x114
input.c:1628: Test failed: wrong position 13, expected 53x106 got 56x112
input.c:1628: Test failed: wrong position 15, expected 51x102 got 55x110
input.c:1628: Test failed: wrong position 18, expected 48x96 got 53x106
input.c:1628: Test failed: wrong position 21, expected 45x90 got 55x110
input.c:1628: Test failed: wrong position 29, expected 37x74 got 51x102
input.c:1628: Test failed: wrong position 30, expected 36x72 got 50x100
input.c:1628: Test failed: wrong position 33, expected 33x66 got 49x98
input.c:1628: Test failed: wrong position 35, expected 31x62 got 48x96
input.c:1628: Test failed: wrong position 36, expected 30x60 got 45x90
input.c:1628: Test failed: wrong position 37, expected 29x58 got 44x88
input.c:1628: Test failed: wrong position 39, expected 27x54 got 43x86
input.c:1628: Test failed: wrong position 41, expected 25x50 got 42x84
input.c:1628: Test failed: wrong position 43, expected 23x46 got 45x90
input.c:1628: Test failed: wrong position 50, expected 16x32 got 38x76
input.c:1628: Test failed: wrong position 51, expected 15x30 got 40x80
input.c:1628: Test failed: wrong position 52, expected 14x28 got 37x74
input.c:1628: Test failed: wrong position 55, expected 11x22 got 38x76
input.c:1628: Test failed: wrong position 56, expected 10x20 got 35x70
input.c:1628: Test failed: wrong position 57, expected 9x18 got 34x68
input.c:1628: Test failed: wrong position 59, expected 7x14 got 33x66
input.c:1628: Test failed: wrong position 60, expected 6x12 got 32x64
input.c:1628: Test failed: wrong position 61, expected 5x10 got 36x72

=== debian11 (32 bit Chinese:China report) ===

user32:
input.c:2164: Test failed: Unexpected rawinput data: -5
input.c:1628: Test failed: wrong position 16, expected 50x100 got 59x118
input.c:1628: Test failed: wrong position 19, expected 47x94 got 54x108
input.c:1628: Test failed: wrong position 23, expected 43x86 got 52x104
input.c:1628: Test failed: wrong position 28, expected 38x76 got 53x106
input.c:1628: Test failed: wrong position 31, expected 35x70 got 48x96
input.c:1628: Test failed: wrong position 50, expected 16x32 got 38x76
input.c:1628: Test failed: wrong position 58, expected 8x16 got 35x70
input.c:1628: Test failed: wrong position 62, expected 4x8 got 32x64
win.c:10994: Test failed: GetForegroundWindow() = 00000000
win.c:10999: Test failed: Expected foreground window 000F015C, got 010500F2
win.c:11002: Test failed: Received WM_ACTIVATEAPP(1), did not expect it.
win.c:11003: Test failed: Received WM_ACTIVATEAPP(0), did not expect it.
win.c:11011: Test failed: Expected foreground window 000F015C, got 00000000
win.c:11013: Test failed: GetActiveWindow() = 00000000
win.c:11013: Test failed: GetFocus() = 00000000
win.c:11021: Test failed: Received WM_ACTIVATEAPP(1), did not expect it.
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11763: Test failed: 007200FE: expected NOT topmost
win.c:11787: Test failed: 007200FE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost
win.c:11810: Test failed: 003300AC: expected NOT topmost
win.c:11811: Test failed: 007200FE: expected next 00070144, got 00000000
win.c:11811: Test failed: 007200FE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost
win.c:11834: Test failed: 003300AC: expected NOT topmost
win.c:11835: Test failed: 007200FE: expected next 00070144, got 00000000
win.c:11835: Test failed: 007200FE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost
win.c:11869: Test failed: 007200FE: expected next 00070144, got 00000000
win.c:11869: Test failed: 007200FE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost
win.c:11892: Test failed: 007200FE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost
win.c:11903: Test failed: 007200FE: expected next 00070144, got 00000000
win.c:11903: Test failed: 007200FE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost
win.c:11606: Test failed: 1: hwnd 003300AC is still topmost
win.c:11606: Test failed: 2: hwnd 005600BA is still topmost
win.c:11606: Test failed: 3: hwnd 00070144 is still topmost
win.c:11606: Test failed: 4: hwnd 007200FE is still topmost

=== debian11 (32 bit WoW report) ===

user32:
input.c:2160: Test failed: GetRawInputBuffer returned 7
input.c:2162: Test failed: Unexpected rawinput data: 0
input.c:2164: Test failed: Unexpected rawinput data: -2
input.c:1628: Test failed: wrong position 5, expected 61x122 got 64x128
input.c:1628: Test failed: wrong position 6, expected 60x120 got 61x122
input.c:1628: Test failed: wrong position 7, expected 59x118 got 63x126
input.c:1628: Test failed: wrong position 8, expected 58x116 got 60x120
input.c:1628: Test failed: wrong position 10, expected 56x112 got 59x118
input.c:1628: Test failed: wrong position 12, expected 54x108 got 61x122
input.c:1628: Test failed: wrong position 15, expected 51x102 got 57x114
input.c:1628: Test failed: wrong position 16, expected 50x100 got 56x112
input.c:1628: Test failed: wrong position 26, expected 40x80 got 51x102
input.c:1628: Test failed: wrong position 34, expected 32x64 got 50x100
input.c:1628: Test failed: wrong position 36, expected 30x60 got 48x96
input.c:1628: Test failed: wrong position 37, expected 29x58 got 46x92
input.c:1628: Test failed: wrong position 41, expected 25x50 got 46x92
input.c:1628: Test failed: wrong position 48, expected 18x36 got 42x84
input.c:1628: Test failed: wrong position 49, expected 17x34 got 40x80
input.c:1628: Test failed: wrong position 51, expected 15x30 got 41x82
input.c:1628: Test failed: wrong position 52, expected 14x28 got 38x76
input.c:1628: Test failed: wrong position 56, expected 10x20 got 39x78
input.c:1628: Test failed: wrong position 58, expected 8x16 got 35x70
input.c:1628: Test failed: wrong position 59, expected 7x14 got 37x74
input.c:1628: Test failed: wrong position 63, expected 3x6 got 35x70

=== debian11 (64 bit WoW report) ===

user32:
win.c:11361: Test failed: expected 0000000000C00102, got 0000000001520076
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11763: Test failed: 00000000008C00EE: expected NOT topmost
win.c:11787: Test failed: 00000000008C00EE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost
win.c:11810: Test failed: 0000000000580160: expected NOT topmost
win.c:11811: Test failed: 00000000008C00EE: expected next 0000000000070146, got 0000000000000000
win.c:11811: Test failed: 00000000008C00EE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost
win.c:11834: Test failed: 0000000000580160: expected NOT topmost
win.c:11835: Test failed: 00000000008C00EE: expected next 0000000000070146, got 0000000000000000
win.c:11835: Test failed: 00000000008C00EE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost
win.c:11869: Test failed: 00000000008C00EE: expected next 0000000000070146, got 0000000000000000
win.c:11869: Test failed: 00000000008C00EE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost
win.c:11892: Test failed: 00000000008C00EE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost
win.c:11903: Test failed: 00000000008C00EE: expected next 0000000000070146, got 0000000000000000
win.c:11903: Test failed: 00000000008C00EE: expected NOT topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost
win.c:11606: Test failed: 1: hwnd 0000000000580160 is still topmost
win.c:11606: Test failed: 2: hwnd 00000000001C0060 is still topmost
win.c:11606: Test failed: 3: hwnd 0000000000070146 is still topmost
win.c:11606: Test failed: 4: hwnd 00000000008C00EE is still topmost