[PATCH] user32: use SWP_NOACTIVATE flag when resizing etched static control

[Jinoh Kang]

On 4/10/22 04:48, Rafal Harabień wrote:
> I through so but after my previous iteration of sending patches, patches that passed CI were merged and this one got ignored so I concluded that Testbot failure was the reason. I am trying to contribute this patch for 1.5 month already (it was first sent on 24 Feb and Testbot didn't fail at that time). It is super small, looks non-controversial for me and fixes issues that I introduced in my other patch so I don't know what could possibly be the reason for it not being merged.

I'm not a maintainer, but here's a few things you could add to make your patch more convincing:

1. An explanation for why the patch is necessary, and would not probably introduce other regression.
2. A unit test that justifies the fix, and ensures that regression that you previously introduced won't happen again.
3. An associated bug report (https://bugs.winehq.org/), linked with a trailer "Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=<ID>".

> 
> <rant-mode>It is not the first time I wait weeks for my patches to be merged or at least reviewed. Seeing how fast patches from CodeWeavers employees are merged (around 1 day) I have impression that this project is unwelcoming to outsiders and it makes me sad.</rant-mode>

See: https://wiki.winehq.org/Developer_FAQ#I_sent_a_patch.2C_but_it_got_ignored._Why.3F

> 
> On 09.04.2022 15:47, Jinoh Kang wrote:
>> On 4/9/22 21:58, Rafal Harabień wrote:
>>> This test is broken on the master branch... I can see similar failures with other patches. My change could not cause it.
>> It's commonplace.  You don't actually have to explain it.
>>
>>


-- 
Sincerely,
Jinoh Kang