[PATCH v3 3/4] dlls/{ntdll, kernel*}: provide a pseudo console environment for initial CUI processes not tied to an Unix tty

[Eric Pouech]

Le 11/04/2022 à 12:15, Jacek Caban a écrit :
> On 4/7/22 19:39, Eric Pouech wrote:
>> What do you suggest then ? Include condrv.h and test each individual 
>> manifest constant ?
>
>
> I still think that we could use negative values. Collision with other 
> magic handles does not seem concerning to me, since those handles are 
> limited CreateProcess() interface anyway. Another idea would be to use 
> magic lower bits.

well, as tweaking with ConsoleHandle requires a couple of convolutions 
to get the PROCESS_PARAMS struct, let's assume no app will play with 
that <g>

I'll resend with negative values then

>
>
> BTW, I'd also consider WARN() instead of once+FIXME() for 
> console_ioctl().

the rationale behind this one was to be able to track when some program 
ends up using Console* interface while being attached to the 
shell_no_screen console type

this could be complicated to track or understand

(actually an ERR would be perhaps more suited than a FIXME)

A+