[PATCH 1/6] conhost: Move console registry key path into 'struct console'

[Jacek Caban]

Hi Hugh,

On 4/11/22 14:35, Hugh McMaster wrote:
> Signed-off-by: Hugh McMaster<hugh.mcmaster at outlook.com>
> ---
>   programs/conhost/conhost.h |  1 +
>   programs/conhost/window.c  | 15 +++++++--------
>   2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/programs/conhost/conhost.h b/programs/conhost/conhost.h
> index 8ca09bb80d0..2cb9515037a 100644
> --- a/programs/conhost/conhost.h
> +++ b/programs/conhost/conhost.h
> @@ -77,6 +77,7 @@ struct console
>       HANDLE                 server;              /* console server handle */
>       unsigned int           mode;                /* input mode */
>       struct screen_buffer  *active;              /* active screen buffer */
> +    WCHAR                 *config_key;          /* registry key name for app-specific settings */
>       int                    is_unix;             /* UNIX terminal mode */
>       int                    use_relative_cursor; /* use relative cursor positionning */
>       INPUT_RECORD          *records;             /* input records */


Why do you need that change? It seems to me that when it's needed, we 
always have console_window struct available anyway. Similar question to 
patches 2, 3, and 4 of the series, it's not obvious to me what's the 
plan for them.


Thanks,

Jacek