[PATCH 3/5] cmd: Fix an off-by-one error in WCMD_expand_envvar().

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=112702

Your paranoid android.


=== w7u_2qxl (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w7u_adm (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w7u_el (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w8 (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w8adm (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w864 (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064v1507 (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064v1809 (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064 (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064_tsign (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w10pro64 (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w864 (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064v1507 (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064v1809 (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064 (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064_2qxl (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w1064_tsign (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w10pro64 (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w10pro64_ar (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w10pro64_he (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w10pro64_ja (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== w10pro64_zh_CN (64 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x74 position 0 in line 1229 (got 'time /t != %time:~2,3%', wanted 'Match')

=== debian11 (32 bit report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1228 (got 'Too long', wanted 'End of %time%')

=== debian11 (32 bit German report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')

=== debian11 (32 bit Hebrew:Israel report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1227 (got 'Too short', wanted '%time% has 1/100s')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1228 (got 'Too long', wanted 'End of %time%')

=== debian11 (32 bit Hindi:India report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1228 (got 'Too long', wanted 'End of %time%')

=== debian11 (32 bit Japanese:Japan report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1227 (got 'Too short', wanted '%time% has 1/100s')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1228 (got 'Too long', wanted 'End of %time%')

=== debian11 (32 bit Chinese:China report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')

=== debian11 (32 bit WoW report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1228 (got 'Too long', wanted 'End of %time%')

=== debian11 (64 bit WoW report) ===

cmd.exe:
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1222 (got 'Too short', wanted 'Good %date%')
batch.c:321: Test failed: unexpected char 0x54 position 0 in line 1228 (got 'Too long', wanted 'End of %time%')