[PATCH resend] server: Avoid reqeuests with null pointer but invalid size.

Alexandre Julliard julliard at winehq.org
Tue Apr 19 10:43:10 CDT 2022


Bernhard Übelacker <bernhardu at mailbox.org> writes:

> @@ -71,7 +71,7 @@ static inline data_size_t wine_server_reply_size( const void *reply )
>  static inline void wine_server_add_data( void *req_ptr, const void *ptr, data_size_t size )
>  {
>      struct __server_request_info * const req = req_ptr;
> -    if (size)
> +    if (size && ptr != NULL)
>      {
>          req->data[req->data_count].ptr = ptr;
>          req->data[req->data_count++].size = size;

That doesn't belong here, it's up to the callers to validate the
pointers when necessary.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list