[PATCH v2 1/6] jscript: Implement Number.prototype.toLocaleString.
Jacek Caban
jacek at codeweavers.com
Thu Apr 21 07:45:14 CDT 2022
Hi Gabriel,
On 4/20/22 18:56, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu<gabrielopcode at gmail.com>
> ---
>
> I kept the fraction removal since I couldn't think of a better way for
> now. However, the other improvements have been done.
Could we just modify the existing toString() code to optionally take
into account localized separators and required customizations? It seems
to me that avoiding exponential form is simply a matter of using a
larger buffer for localized string.
Also, it would be nice to have better tests. For jscript mode, you
should be able to change GetLCID() to force using English locale. For
HTML mode, you may run those tests only for English locale.
Thanks,
Jacek
More information about the wine-devel
mailing list