[PATCH 5/6] windows.media.speech/tests: Remove racing tests.

[Rémi Bernon]

On 4/21/22 16:54, Rémi Bernon wrote:
> On 4/20/22 21:34, Bernhard Kölbl wrote:
>> Signed-off-by: Bernhard Kölbl <besentv at gmail.com>
>> ---
>>   dlls/windows.media.speech/tests/speech.c | 9 +--------
>>   1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/dlls/windows.media.speech/tests/speech.c 
>> b/dlls/windows.media.speech/tests/speech.c
>> index dd699da9bcd..908e04bb0c3 100644
>> --- a/dlls/windows.media.speech/tests/speech.c
>> +++ b/dlls/windows.media.speech/tests/speech.c
>> @@ -974,7 +974,6 @@ static void test_SpeechRecognizer(void)
>>           hr = 
>> IAsyncOperation_SpeechRecognitionCompilationResult_put_Completed(operation, 
>> &compilation_handler.IAsyncHandler_Compilation_iface);
>>           todo_wine ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
>> -        todo_wine 
>> check_refcount(&compilation_handler.IAsyncHandler_Compilation_iface, 1);
>>           todo_wine 
>> ok(!WaitForSingleObject(compilation_handler.event_finished, 1000), 
>> "Wait for event_finished failed.\n");
>>           CloseHandle(compilation_handler.event_finished);
>> @@ -1061,16 +1060,10 @@ static void test_SpeechRecognizer(void)
>>           hr = 
>> IAsyncOperation_SpeechRecognitionCompilationResult_QueryInterface(operation, 
>> &IID_IAsyncInfo, (void **)&info);
>>           todo_wine ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
>> -        /* This one can fail, if the async operation had already 
>> finished */
>> -        compilation_result = (void*)0xdeadbeef;
>> -        hr = 
>> IAsyncOperation_SpeechRecognitionCompilationResult_GetResults(operation, 
>> &compilation_result);
>> -        todo_wine ok(hr == E_ILLEGAL_METHOD_CALL, "Got unexpected hr 
>> %#lx.\n", hr);
>> -        todo_wine ok(compilation_result == (void*)0xdeadbeef, 
>> "Compilation result had value %p.\n", compilation_result);
>> -
>>           async_status = 0xdeadbeef;
>>           hr = IAsyncInfo_get_Status(info, &async_status);
>>           todo_wine ok(hr == S_OK, "IAsyncInfo_get_Status failed, hr 
>> %#lx.\n", hr);
>> -        todo_wine ok(async_status == Started || async_status == 
>> Completed, "Status was %#x.\n", async_status);
>> +        todo_wine ok(async_status != AsyncStatus_Closed, "Status was 
>> %#x.\n", async_status);
>>           hr = 
>> IAsyncOperation_SpeechRecognitionCompilationResult_put_Completed(operation, 
>> &compilation_handler2.IAsyncHandler_Compilation_iface);
>>           todo_wine ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
> 
> 
> Looks alright, but as you should probably remove the test from PATCH 3, 
> I suggest you squash this with it.
> 

PATCH 4 sorry.
-- 
Rémi Bernon <rbernon at codeweavers.com>