[PATCH 1/2] mshtmlmedia: Add dll.

[Austin English]

On Sat, Apr 23, 2022, 07:17 Nikolay Sivov <nsivov at codeweavers.com> wrote:

> On 4/23/22 11:57, Mohamad Al-Jaf wrote:
> > On Sat, Apr 23, 2022 at 4:01 AM Nikolay Sivov <nsivov at codeweavers.com>
> wrote:
> >> What I mean is, have you checked that?
> > Why would that be necessary? It's clear that the game tries to load
> > mshtmlmedia under Windows 7 so why wouldn't this be the case in Wine
> > running in Windows 7 mode?
>
> Testing on wine would be necessary to see if it's needed.


I have to agree with Mohamad here. AFAIK, it's never been a requirement
that a patch actually be verified before committing it:

1) I don't see it mentioned on https://wiki.winehq.org/Submitting_Patches

2) There are over a thousand bugs that have been closed fixed that contain
the comment 'Should be fixed by':
https://bugs.winehq.org/buglist.cgi?bug_status=CLOSED&limit=0&list_id=762726&longdesc=should%20be%20fixed%20by&longdesc_type=substring&order=bug_id&product=Wine&query_format=advanced&resolution=FIXED

(I realize that isn't an accurate count, but demonstrates my broader point).

If there's constructive feedback that hasn't been given, by all means, give
it, but "it hasn't been explicitly tested" isn't a reason to block in
standard wine development. Maybe we should revisit that, but until we do, I
don't think it should block this patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20220424/bec5f4d7/attachment.htm>