[PATCH 1/6] dinput/tests: Remove unreliable IAsyncOperation_boolean checks.
Rémi Bernon
rbernon at codeweavers.com
Mon Apr 25 07:56:15 CDT 2022
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
dlls/dinput/tests/force_feedback.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/dlls/dinput/tests/force_feedback.c b/dlls/dinput/tests/force_feedback.c
index a4588f7022d..42f3bdc84c7 100644
--- a/dlls/dinput/tests/force_feedback.c
+++ b/dlls/dinput/tests/force_feedback.c
@@ -5395,8 +5395,7 @@ static void test_windows_gaming_input(void)
check_bool_async( bool_async, 1, 4, S_OK, FALSE );
IAsyncInfo_Release( async_info );
- ref = IAsyncOperation_boolean_Release( bool_async );
- ok( ref == 0, "Release returned %lu\n", ref );
+ IAsyncOperation_boolean_Release( bool_async );
set_hid_expect( file, &expect_enable_fail, sizeof(expect_enable_fail) );
@@ -5423,8 +5422,7 @@ static void test_windows_gaming_input(void)
check_bool_async( bool_async, 1, 4, 0x8685400d, FALSE );
IAsyncInfo_Release( async_info );
- ref = IAsyncOperation_boolean_Release( bool_async );
- ok( ref == 0, "Release returned %lu\n", ref );
+ IAsyncOperation_boolean_Release( bool_async );
/* canceling the async op is just ignored */
@@ -5468,8 +5466,7 @@ static void test_windows_gaming_input(void)
ok( hr == S_OK, "get_Completed returned %#lx\n", hr );
ok( tmp_handler == NULL, "got handler %p\n", tmp_handler );
- ref = IAsyncOperation_boolean_Release( bool_async );
- ok( ref == 0, "Release returned %lu\n", ref );
+ IAsyncOperation_boolean_Release( bool_async );
/* canceling then closing it calls the handler with closed state */
@@ -5514,8 +5511,7 @@ static void test_windows_gaming_input(void)
hr = IAsyncOperation_boolean_get_Completed( bool_async, &tmp_handler );
ok( hr == E_ILLEGAL_METHOD_CALL, "get_Completed returned %#lx\n", hr );
- ref = IAsyncOperation_boolean_Release( bool_async );
- ok( ref == 0, "Release returned %lu\n", ref );
+ IAsyncOperation_boolean_Release( bool_async );
set_hid_expect( file, &expect_enable, sizeof(expect_enable) );
@@ -5523,9 +5519,7 @@ static void test_windows_gaming_input(void)
todo_wine
ok( hr == S_OK, "TryEnableAsync returned %#lx\n", hr );
wait_hid_expect_( __FILE__, __LINE__, file, 100, TRUE );
- check_bool_async( bool_async, 1, Completed, S_OK, TRUE );
- ref = IAsyncOperation_boolean_Release( bool_async );
- ok( ref == 0, "Release returned %lu\n", ref );
+ IAsyncOperation_boolean_Release( bool_async );
set_hid_expect( file, expect_reset, sizeof(expect_reset) );
@@ -5533,9 +5527,7 @@ static void test_windows_gaming_input(void)
todo_wine
ok( hr == S_OK, "TryResetAsync returned %#lx\n", hr );
wait_hid_expect_( __FILE__, __LINE__, file, 100, TRUE );
- check_bool_async( bool_async, 1, Completed, S_OK, TRUE );
- ref = IAsyncOperation_boolean_Release( bool_async );
- ok( ref == 0, "Release returned %lu\n", ref );
+ IAsyncOperation_boolean_Release( bool_async );
IForceFeedbackMotor_Release( motor );
--
2.35.1
More information about the wine-devel
mailing list