[tools] testbot/cgi: Fix ItemPage's iteration over the master columns.

Francois Gouget fgouget at codeweavers.com
Mon Apr 25 11:49:21 CDT 2022


GenerateFormStart() went one iteration too far which is okay only
because our pages never have master columns in the first place.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/ObjectModel/CGI/ItemPage.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testbot/lib/ObjectModel/CGI/ItemPage.pm b/testbot/lib/ObjectModel/CGI/ItemPage.pm
index b88e27394..1b77eea01 100644
--- a/testbot/lib/ObjectModel/CGI/ItemPage.pm
+++ b/testbot/lib/ObjectModel/CGI/ItemPage.pm
@@ -109,7 +109,7 @@ sub GenerateFormStart($)
   my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
   if (defined($MasterColNames))
   {
-    foreach my $ColIndex (0 .. @$MasterColNames)
+    foreach my $ColIndex (0..$#{$MasterColNames})
     {
       print "<div><input type='hidden' name='", $MasterColNames->[$ColIndex],
             "' value='", $self->escapeHTML($MasterColValues->[$ColIndex]),
@@ -146,7 +146,7 @@ sub RedirectToList($)
   my ($MasterColNames, $MasterColValues) = $self->{Collection}->GetMasterCols();
   if (defined($MasterColNames))
   {
-    foreach my $ColIndex (0 .. @$MasterColNames - 1)
+    foreach my $ColIndex (0..$#{$MasterColNames})
     {
       $Target .= ($ColIndex == 0 ? "?" : "&") . $MasterColNames->[$ColIndex] .
                  "=" . url_escape($MasterColValues->[$ColIndex]);
-- 
2.30.2



More information about the wine-devel mailing list