[PATCH] programs/sc: Allow using separate arguments for parameter name and value.

[Alexandre Julliard]

Torge Matthies <tmatthies at codeweavers.com> writes:

> On 4/25/22 20:17, Dmitry Timoshkov wrote:
>> Torge Matthies <tmatthies at codeweavers.com> wrote:
>> 
>>> In addition to using one argument for both parameter name and value.
>>>
>>> This fixes a regression from commit 8b38c91d83844dea882922055ced7cdeb79c1693.
>> Could you please clarify what precisely is the regression caused by
>> the
>> mentioned above commit, and provide some examples which command lines
>> were broken and started to work with your patch.
>> 
>
> The mentioned commit broke commands like:
>
>     sc.exe create test binpath= C:\windows\system32\cmd.exe
>
> and:
>
>     sc.exe create test binpath= C:\windows\system32\cmd.exe
>     displayname= "Test Service" start= auto
>
> All sc create or sc failure commands where the parameter names and
> values are separated by a space are affected.
>
> Should I add the commands above to the commit message?

If possible, adding some test cases would be preferable.

-- 
Alexandre Julliard
julliard at winehq.org