[PATCH 6/6] winemac.drv: Restore check to skip a window update when it is closing.

Tim Clem tclem at codeweavers.com
Mon Apr 25 15:21:38 CDT 2022


Consider this withdrawn for now.

Discussion on this series continues on the Bugzilla bug. I'm exploring the
possibilities other than a full revert. If we end up going this route, I'll
resubmit.

Thanks!
--Tim

April 21, 2022 1:05 PM, "Tim Clem" <tclem at codeweavers.com> wrote:

> This restores the check from 6bb537c8b0c that was partially reverted
> along with 9e599a89e30.
> 
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52231
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52354
> Signed-off-by: Tim Clem <tclem at codeweavers.com>
> ---
> dlls/winemac.drv/cocoa_window.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m
> index 5cf2ae6bc25..54189c251d4 100644
> --- a/dlls/winemac.drv/cocoa_window.m
> +++ b/dlls/winemac.drv/cocoa_window.m
> @@ -494,7 +494,7 @@ - (void) drawRect:(NSRect)rect
> NSRectFill(rect);
> }
> 
> - if (window.surface && window.surface_mutex &&
> + if (!window.closing && window.surface && window.surface_mutex &&
> !pthread_mutex_lock(window.surface_mutex))
> {
> const CGRect* rects;
> -- 
> 2.34.1



More information about the wine-devel mailing list