[PATCH v2 2/2] iphlpapi: Add GetPerTcpConnectionEStats stub.

Huw Davies huw at codeweavers.com
Tue Apr 26 01:38:57 CDT 2022


On Tue, Apr 26, 2022 at 12:00:10AM -0400, Mohamad Al-Jaf wrote:
> From: Austin English <austinenglish at gmail.com>
> 
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52677
> Signed-off-by: Mohamad Al-Jaf <mohamadaljaf at gmail.com>
> ---
> v2: - Formatting.
>     - Add prototype.
>     - Remove rw = ro_static = ro_dynamic = NULL.
> 
> I don't think the above line is needed.
> 
> Screenshot: https://i.imgur.com/RkzgjBG.png
> 
> Austin signed-off on his original patch but I didn't add it
> here because of the above changes.
> 
> Please don't commit this unless Austin signs off on it.
> 
> Thanks again, Austin. :)

I don't think it's unreasonable to wait for Austin to send in his own
patches (especially as you're asking the reviewer to wait until Austin
sends his sign-off).  I appreciate that you've made some changes, but
this would be better done in response to a patch that's actually on
the mailing list.  That way the reviewer can easily follow the
progress, unlike the way this was done, which just left me confused
about where v1 was.

Huw.



More information about the wine-devel mailing list