[v3 PATCH] mfplay: Prevent usage of uninitialized pointer in error case (Coverity)
Nikolay Sivov
nsivov at codeweavers.com
Wed Apr 27 06:44:40 CDT 2022
From: Fabian Maurer <dark.shadow4 at web.de>
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
v3: make sure pointers are zeroed for every stream.
dlls/mfplay/player.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dlls/mfplay/player.c b/dlls/mfplay/player.c
index 7d9a4da8649..c500717b8d0 100644
--- a/dlls/mfplay/player.c
+++ b/dlls/mfplay/player.c
@@ -1378,7 +1378,6 @@ static HRESULT media_item_create_sink_node(IUnknown *sink, IMFTopologyNode **nod
static HRESULT media_item_create_topology(struct media_player *player, struct media_item *item, IMFTopology **out)
{
- IMFTopologyNode *src_node, *sink_node;
BOOL selected, video_added = FALSE;
IMFStreamDescriptor *sd;
IMFTopology *topology;
@@ -1421,6 +1420,8 @@ static HRESULT media_item_create_topology(struct media_player *player, struct me
if (sink)
{
+ IMFTopologyNode *src_node = NULL, *sink_node = NULL;
+
hr = media_item_create_source_node(item, sd, &src_node);
if (SUCCEEDED(hr))
hr = media_item_create_sink_node(sink, &sink_node);
--
2.35.1
More information about the wine-devel
mailing list