[PATCH 3/5] makedep: Fix some signed vs unsigned msvc warnings.

Stefan Dösinger stefan at codeweavers.com
Tue Feb 1 07:58:23 CST 2022


Signed-off-by: Stefan Dösinger <stefan at codeweavers.com>

---

Those seem just right to fix without making the code uglier. 3 Are left in
main where the same iterator is compared to signed and unsigned values. I
am leaving those 3 alone since I don't think fixing them improves anything.
---
 tools/makedep.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tools/makedep.c b/tools/makedep.c
index 4172720fbf0..edb5d5a42d0 100644
--- a/tools/makedep.c
+++ b/tools/makedep.c
@@ -2036,7 +2036,7 @@ static const char *get_native_unix_lib( const struct makefile *make, const char
 static struct makefile *get_parent_makefile( struct makefile *make )
 {
     char *dir, *p;
-    int i;
+    unsigned int i;
 
     if (!make->obj_dir) return NULL;
     dir = xstrdup( make->obj_dir );
@@ -3924,7 +3924,7 @@ static void output_testlist( const struct makefile *make )
  */
 static void output_gitignore( const char *dest, struct strarray files )
 {
-    int i;
+    unsigned int i;
 
     output_file = create_temp_file( dest );
 
@@ -4026,7 +4026,8 @@ static void output_top_makefile( struct makefile *make )
 {
     char buffer[1024];
     FILE *src_file;
-    int i, found = 0;
+    unsigned int i;
+    int found = 0;
 
     output_file_name = obj_dir_path( make, output_makefile_name );
     output_file = create_temp_file( output_file_name );
-- 
2.34.1




More information about the wine-devel mailing list