[PATCH] winspool: Fix memory leaks on error path in DeviceCapabilitiesA (Coverity)

Alex Henrie alexhenrie24 at gmail.com
Wed Feb 2 22:35:01 CST 2022


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 dlls/winspool.drv/info.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c
index 971eb654e6a..52edd362622 100644
--- a/dlls/winspool.drv/info.c
+++ b/dlls/winspool.drv/info.c
@@ -1775,7 +1775,7 @@ INT WINAPI DeviceCapabilitiesA(const char *device, const char *portA, WORD cap,
         WCHAR *outputW;
 
         ret = DeviceCapabilitiesW(device_name, port, cap, NULL, devmode);
-        if (ret == -1) return ret;
+        if (ret == -1) goto cleanup;
 
         switch (cap) {
         case DC_BINNAMES:
@@ -1795,6 +1795,7 @@ INT WINAPI DeviceCapabilitiesA(const char *device, const char *portA, WORD cap,
     } else {
         ret = DeviceCapabilitiesW(device_name, port, cap, (WCHAR *)output, devmode);
     }
+cleanup:
     HeapFree(GetProcessHeap(), 0, device_name);
     HeapFree(GetProcessHeap(), 0, devmode);
     HeapFree(GetProcessHeap(), 0, port);
-- 
2.35.1




More information about the wine-devel mailing list