[PATCH 3/4] quartz/filtergraph: Remove redundant checks for pin direction from CheckCircularConnection().

Zebediah Figura zfigura at codeweavers.com
Wed Feb 2 22:58:08 CST 2022


These are already checked in the callers.

Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
---
 dlls/quartz/filtergraph.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
index aa646615428..74f1adcb665 100644
--- a/dlls/quartz/filtergraph.c
+++ b/dlls/quartz/filtergraph.c
@@ -782,22 +782,12 @@ static HRESULT CheckCircularConnection(struct filter_graph *This, IPin *out, IPi
     hr = IPin_QueryPinInfo(out, &info_out);
     if (FAILED(hr))
         return hr;
-    if (info_out.dir != PINDIR_OUTPUT)
-    {
-        IBaseFilter_Release(info_out.pFilter);
-        return VFW_E_CANNOT_CONNECT;
-    }
 
     hr = IPin_QueryPinInfo(in, &info_in);
     if (SUCCEEDED(hr))
         IBaseFilter_Release(info_in.pFilter);
     if (FAILED(hr))
         goto out;
-    if (info_in.dir != PINDIR_INPUT)
-    {
-        hr = VFW_E_CANNOT_CONNECT;
-        goto out;
-    }
 
     if (info_out.pFilter == info_in.pFilter)
         hr = VFW_E_CIRCULAR_GRAPH;
-- 
2.34.1




More information about the wine-devel mailing list