[PATCH] winegcc: --out-implib needs to propagate -m32/-m64 to winebuild.

Kevin Puetz PuetzKevinA at JohnDeere.com
Thu Feb 3 15:43:51 CST 2022


Alexandre Julliard <julliard at winehq.org> writes:

> This should most likely be done in get_winebuild_args().

I considered that, but that sends -m32/-m64 to subcommands that don't care
e.g. winebuild --fixup-constructors peeks at the ELF magic number instead,
and winebuld --builtin just modifies an existing PE header in-place.
winebuild forwards force_pointer_size in get_as_command and get_ld_command,
so it kind of goes with adding --cc-cmd and --ld-cmd
(which are also not in get_winebuild_args).

That said, winebuild will parse -m32/-m64 whether it needs it or not,
and it does get passed to set_target_ptr_size. So I can see the case
for pairing it up paring it with --target (which is in get_winebuild_args)

I'll send a v2 doing it that way, you can pick whichever you like.




More information about the wine-devel mailing list