[PATCH 3/4] d3dx9: Don't mark annotation variables as dirty.

Zebediah Figura zfigura at codeweavers.com
Mon Feb 7 17:24:34 CST 2022


This fixes a crash when trying to set their value.

Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
---
 dlls/d3dx9_36/effect.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index b8c957245a6..310e5c0bf17 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -1313,10 +1313,15 @@ static void *record_parameter(struct d3dx_effect *effect, struct d3dx_parameter
 
 static void set_dirty(struct d3dx_parameter *param)
 {
-    struct d3dx_shared_data *shared_data;
     struct d3dx_top_level_parameter *top_param = param->top_level_param;
-    ULONG64 new_update_version = next_update_version(top_param->version_counter);
+    struct d3dx_shared_data *shared_data;
+    ULONG64 new_update_version;
 
+    /* This is true for annotations. */
+    if (!top_param)
+        return;
+
+    new_update_version = next_update_version(top_param->version_counter);
     if ((shared_data = top_param->shared_data))
         shared_data->update_version = new_update_version;
     else
-- 
2.34.1




More information about the wine-devel mailing list