[PATCH v4 1/2] user32/tests: Add more tests for WM_NCCALCSIZE.

Dmitry Timoshkov dmitry at baikal.ru
Thu Feb 10 05:54:19 CST 2022


Hi Zhiyi,

Dmitry Timoshkov <dmitry at baikal.ru> wrote:

> > This creates new warnings.
> > 
> > ../dlls/user32/tests/win.c: In function ‘test_ShowWindow_owned’:
> > ../dlls/user32/tests/win.c:7817:23: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘BOOL’ {aka ‘int’} [-Wformat=]
> >  7817 |     ok(!ret, "got %08lx\n", ret);
> >       |                   ~~~~^     ~~~
> >       |                       |     |
> >       |                       |     BOOL {aka int}
> >       |                       long unsigned int
> >       |                   %08x
> > ../dlls/user32/tests/win.c: In function ‘test_ShowWindow_child’:
> > ../dlls/user32/tests/win.c:7950:23: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘BOOL’ {aka ‘int’} [-Wformat=]
> >  7950 |     ok(!ret, "got %08lx\n", ret);
> >       |                   ~~~~^     ~~~
> >       |                       |     |
> >       |                       |     BOOL {aka int}
> >       |                       long unsigned int
> >       |                   %08x
> > ../dlls/user32/tests/win.c: In function ‘test_ShowWindow_mdichild’:
> > ../dlls/user32/tests/win.c:8079:23: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘BOOL’ {aka ‘int’} [-Wformat=]
> >  8079 |     ok(!ret, "got %08lx\n", ret);
> >       |                   ~~~~^     ~~~
> >       |                       |     |
> >       |                       |     BOOL {aka int}
> >       |                       long unsigned int
> >       |                   %08x
> > 
> 
> Thanks for spotting this. I guess that's a gcc/mingw build since I don't see
> these warnings when building with clang.

I also checked with a gcc build and I don't get the warnings above since both
clang and gcc are running with explicit -Wno-format option specified. Could you
please provide more info about your setup? Are you enabling format warnings by
hand?

-- 
Dmitry.



More information about the wine-devel mailing list