[PATCH 0/4] Enabling long types in ntdll
Eric Pouech
eric.pouech at gmail.com
Wed Feb 16 01:31:38 CST 2022
It's time to celebrate!!
With yesterday's commits, half (50%) of the 745 modules have been migrated
with long type compilation.
So celebration it is... with migrating ntdll...
pushing to wine-devel in a dedicated serie to ease versionning (if needed)
A few comments though:
- changes to Unixlib part are not automated (whereas the PE part is).
so given the number of changes, errors may have been integrated.
So double, triple look is welcomed.
- Alexandre suggested to add #define WINE_NO_LONG_TYPES to unix/*.c files
to reduce changes and not useful casts in debug traces
- that would have made 19 files needing that
- I tried to reduce that for files where a) there was easy room for
adaptating types to avoid warnings and/or b) the number of cast to be
added per file was small (say 10)
- that leaves 6 unix/*.c files with #define WINE_NO_LONG_TYPES, they others
being migrated (plus the two arm* signal files that can simply be
migrated as purely compiled as 32 or 64 bit, but I will let folks with
an ARM compiler take care of it)
However, the mixed type definitions among the dlls/ntdll/*.c could be
problematic for maintaining the code.
A+
---
Eric Pouech (4):
dlls/ntdll/unix: reduce use of long type in unixlib's iocontrol routines
dlls/ntdll/unix: don't use long types when possible
dlls/ntdll/unix: use correct integral type
dlls/ntdll: enable compilation with long types
dlls/ntdll/Makefile.in | 2 +-
dlls/ntdll/actctx.c | 34 ++++++-------
dlls/ntdll/atom.c | 2 +-
dlls/ntdll/debugbuffer.c | 40 ++++++++--------
dlls/ntdll/error.c | 2 +-
dlls/ntdll/exception.c | 24 +++++-----
dlls/ntdll/handletable.c | 4 +-
dlls/ntdll/heap.c | 88 +++++++++++++++++-----------------
dlls/ntdll/loader.c | 54 ++++++++++-----------
dlls/ntdll/locale.c | 22 ++++-----
dlls/ntdll/misc.c | 20 ++++----
dlls/ntdll/path.c | 4 +-
dlls/ntdll/reg.c | 10 ++--
dlls/ntdll/relay.c | 28 +++++------
dlls/ntdll/resource.c | 4 +-
dlls/ntdll/rtl.c | 26 +++++-----
dlls/ntdll/rtlbitmap.c | 32 ++++++-------
dlls/ntdll/rtlstr.c | 2 +-
dlls/ntdll/sec.c | 36 +++++++-------
dlls/ntdll/signal_i386.c | 28 +++++------
dlls/ntdll/signal_x86_64.c | 28 +++++------
dlls/ntdll/sync.c | 8 ++--
dlls/ntdll/thread.c | 12 ++---
dlls/ntdll/threadpool.c | 26 +++++-----
dlls/ntdll/unix/cdrom.c | 21 ++++----
dlls/ntdll/unix/debug.c | 12 ++---
dlls/ntdll/unix/env.c | 12 ++---
dlls/ntdll/unix/file.c | 2 +
dlls/ntdll/unix/loader.c | 10 ++--
dlls/ntdll/unix/process.c | 14 +++---
dlls/ntdll/unix/registry.c | 2 +
dlls/ntdll/unix/security.c | 2 +
dlls/ntdll/unix/serial.c | 32 ++++++-------
dlls/ntdll/unix/server.c | 6 +--
dlls/ntdll/unix/signal_arm.c | 2 +
dlls/ntdll/unix/signal_arm64.c | 2 +
dlls/ntdll/unix/signal_i386.c | 22 ++++-----
dlls/ntdll/unix/socket.c | 18 +++----
dlls/ntdll/unix/sync.c | 2 +
dlls/ntdll/unix/system.c | 2 +
dlls/ntdll/unix/tape.c | 34 ++++++-------
dlls/ntdll/unix/thread.c | 17 +++----
dlls/ntdll/unix/unix_private.h | 14 +++---
dlls/ntdll/unix/virtual.c | 2 +
dlls/ntdll/version.c | 6 +--
45 files changed, 394 insertions(+), 376 deletions(-)
More information about the wine-devel
mailing list