[PATCH vkd3d 3/6] vkd3d-shader/hlsl: Support complex numeric initializers.

Giovanni Mascellani gmascellani at codeweavers.com
Thu Feb 17 03:16:58 CST 2022


Hi,

Il 16/02/22 18:59, Francisco Casas ha scritto:
> For now it is the same thing but 4 patches ahead (in the continuation of this batch) that will no
> longer be true.
> The idea is that var may also be a struct or an array, and type would be the type of the numeric
> field inside that we want to initialize.

Yeah, it makes sense.

I think the patches in this series are correct, meaning that as far as I 
can see they do not introduce errors and the general structure of the 
code looks fine. Clearly they leave the code in a very "in the making" 
state, but that's reasonable considering that you still have other work 
to submit and are working actively on this thing, so I am signing off on 
them anyway.

Once you are done with all your patches I might still have a few 
comments, but they are minor enough that to me it makes sense to first 
let the patches in and then, at the end, fix the small leftovers.

Giovanni.



More information about the wine-devel mailing list