[PATCH] ntoskrnl.exe/tests: Let CertCloseStore() delete the certificate context.
Sven Baars
sbaars at codeweavers.com
Fri Feb 18 16:26:30 CST 2022
This should fix test failures caused by ef437b41eebcb54a3576741fc52dbc29caa1590f.
Signed-off-by: Sven Baars <sbaars at codeweavers.com>
---
Apparently our implementation of CertDeleteCertificateFromStore() is wrong instead.
It seems like it should always call CertFreeCertificateContext() internally.
I'm not sure yet of the best way to do this.
dlls/ntoskrnl.exe/tests/ntoskrnl.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/dlls/ntoskrnl.exe/tests/ntoskrnl.c b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
index 6207ce00ccb..13d1af4e7cd 100644
--- a/dlls/ntoskrnl.exe/tests/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/tests/ntoskrnl.c
@@ -233,15 +233,11 @@ static void testsign_cleanup(struct testsign_context *ctx)
ret = CertFreeCertificateContext(ctx->cert);
ok(ret, "Failed to free certificate, error %u\n", GetLastError());
- ret = CertDeleteCertificateFromStore(ctx->root_cert);
- ok(ret, "Failed to remove certificate, error %u\n", GetLastError());
ret = CertFreeCertificateContext(ctx->root_cert);
ok(ret, "Failed to free certificate context, error %u\n", GetLastError());
ret = CertCloseStore(ctx->root_store, CERT_CLOSE_STORE_CHECK_FLAG);
ok(ret, "Failed to close store, error %u\n", GetLastError());
- ret = CertDeleteCertificateFromStore(ctx->publisher_cert);
- ok(ret, "Failed to remove certificate, error %u\n", GetLastError());
ret = CertFreeCertificateContext(ctx->publisher_cert);
ok(ret, "Failed to free certificate context, error %u\n", GetLastError());
ret = CertCloseStore(ctx->publisher_store, CERT_CLOSE_STORE_CHECK_FLAG);
--
2.30.0.335.ge6362826a0
More information about the wine-devel
mailing list