[PATCH 1/2] Add test for RedrawWindow with both validate and internal paint flags.

Roman Pišl rpisl at seznam.cz
Sat Feb 19 13:38:17 CST 2022


Hi Eric,

Dne 19. 02. 22 v 19:49 Eric Pouech napsal(a):
> struct message {
>> @@ -2819,6 +2820,10 @@ static void ok_sequence_(const struct message 
>> *expected_list, const char *contex
>>                   context, count, expected->message);
>>               if ((expected->flags & kbd_hook) != (actual->flags & 
>> kbd_hook)) dump++;
>> +        todo_wine_if(expected->flags & has_update)
>> +        ok_( file, line) (!(expected->flags & has_update) || 
>> (actual->flags & has_update),
>> +        "%s: %u: the msg 0x%04x should have update region\n", 
>> context, count, expected->message );
>> +
>>           expected++;
>>           actual++;
>>       }
> 
> Hi Roman
> 
> please, don't outdent the todo_wine*
> 
> that generates warnings with mingw gcc 11.x
> 
> thanks
> 
> 
> 

unfortunately this code mixes tabs and spaces in a very ugly way - it 
indents by 4 but tab size is expected to be 8. I'll fix it in the next 
version after review..

Or would a patch that removes completely all tabs from the file be 
acceptable?

Thanks

Roman



More information about the wine-devel mailing list