[PATCH 3/8] dllhost: Implement ISurrogate::LoadDllServer().

[Huw Davies]

On Tue, Feb 22, 2022 at 05:04:15PM +0300, Dmitry Timoshkov wrote:
> Dmitry Timoshkov <dmitry at baikal.ru> wrote:
> 
> > > This is generating a few -Wformat warnings:
> > > 
> > > In file included from programs/dllhost/dllhost.c:27:
> > > programs/dllhost/dllhost.c: In function ‘factory_AddRef’:
> > > programs/dllhost/dllhost.c:81:11: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 6 has type ‘ULONG’ {aka ‘long unsigned int’} [-Wformat=]
> > >    81 |     TRACE("(%p)->%u\n", iface, ref);
> > >       |           ^~~~~~~~~~~~         ~~~
> > >       |                                |
> > >       |                                ULONG {aka long unsigned int}
> > > 
> > > Apart from that, the series looks good at first glance.
> > 
> > I don't get the warnings with clang, will check with a gcc build.
> 
> I don't see this warning in an ELF build either. This is a default build,
> nothing custom or special. Is there a trick to enable the warnings?

I'd have thought you'd have seen them in a PE build or in a 32-bit
ELF build - ie. whenever ULONG is unsigned long.

Once you have them fixed, send in the series again.  I didn't spot
anything else that'll need more work.

Huw.