[PATCH v4 2/5] winegstreamer: Move the conditional cleanup to the create error path.

Rémi Bernon rbernon at codeweavers.com
Tue Feb 22 12:03:52 CST 2022


On 2/22/22 18:43, Zebediah Figura wrote:
>   
> +out_free_sink_caps:
> +    gst_caps_unref(sink_caps);
> +out_free_src_pad:
> +    gst_object_unref(transform->my_src);
> +out_free_src_caps:
> +    gst_caps_unref(src_caps);
> +out_free_transform:
> +    free(transform);
> +    GST_ERROR("Failed to create winegstreamer transform.");
>       return status;
>   }

I hesitated with an approach like this. I haven't seen goto dipatch like 
this elsewhere so I thought it wasn't the preferred style.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list