[PATCH 4/4] winegstreamer: Introduce new H264 decoder transform stub.

Rémi Bernon rbernon at codeweavers.com
Thu Feb 24 02:56:27 CST 2022


On 2/24/22 09:50, Rémi Bernon wrote:
>   
> +static WCHAR h264_decoderW[] = L"Microsoft H264 Video Decoder MFT";
> +static const GUID *h264_decoder_input_types[] =
> +{
> +    &MFVideoFormat_H264,
> +    &MFVideoFormat_H264_ES,
> +};
> +static const GUID *h264_decoder_output_types[] =
> +{
> +    &MFVideoFormat_NV12,
> +    &MFVideoFormat_YV12,
> +    &MFVideoFormat_IYUV,
> +    &MFVideoFormat_I420,
> +    &MFVideoFormat_YUY2,
> +};
> +

As usual, looking at it *after* pressing the send button, I think this 
could use more const.

Anyway, I'm actually more interested by the tests, and this patch was to 
assert that they would pass with the stub too.

Adding the transform now will also cause some unfortunate regressions 
(because some games better handle its absence than a stub), which may 
not be ideal for next release.
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list