[PATCH 1/5] dinput/tests: Add some windows.gaming.input hotplug tests.

[Rémi Bernon]

On 2/25/22 15:32, Francois Gouget wrote:
> On Wed, 23 Feb 2022, Rémi Bernon wrote:
> 
>> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
>> ---
>>   dlls/dinput/tests/Makefile.in |   2 +-
>>   dlls/dinput/tests/hotplug.c   | 244 ++++++++++++++++++++++++++++++++++
>>   2 files changed, 245 insertions(+), 1 deletion(-)
>>
>> diff --git a/dlls/dinput/tests/Makefile.in b/dlls/dinput/tests/Makefile.in
>> index 5ba0e5be4d7..d32092ca03b 100644
>> --- a/dlls/dinput/tests/Makefile.in
>> +++ b/dlls/dinput/tests/Makefile.in
>> @@ -1,5 +1,5 @@
>>   TESTDLL   = dinput.dll
>> -IMPORTS   = dinput dinput8 ole32 version user32 advapi32 hid uuid crypt32 newdev setupapi wintrust winmm
>> +IMPORTS   = dinput dinput8 ole32 version user32 advapi32 hid uuid crypt32 newdev setupapi wintrust winmm combase
> 
> Linking with combase.dll prevents the dinput tests from running on
> Windows 7:
> 
> https://testbot.winehq.org/JobDetails.pl?Key=109252&f202=exe32.report#k202
> https://test.winehq.org/data/patterns.html#dinput:dinput
> 
> Before that they may have been skipping some tests on Windows 7
> but it appears they were still running quite a few:
> 
> 0798:device: 7517168 tests executed (0 marked as todo, 0 failures), 1 skipped.
> 0b34:device8: 1915 tests executed (0 marked as todo, 0 failures), 1 skipped.
> 0070:dinput: 2375 tests executed (0 marked as todo, 0 failures), 1 skipped.
> ...
> 

Ah, thanks for spotting this, I'll make the dependency optional.
-- 
Rémi Bernon <rbernon at codeweavers.com>