[PATCH v2] combase: Add RoSetErrorReportingFlags stub

Huw Davies huw at codeweavers.com
Mon Feb 28 04:21:57 CST 2022


On Fri, Feb 25, 2022 at 07:19:46PM +1100, Alistair Leslie-Hughes wrote:
> diff --git a/dlls/combase/roapi.c b/dlls/combase/roapi.c
> index 0a17f02b776..6dd714a8275 100644
> --- a/dlls/combase/roapi.c
> +++ b/dlls/combase/roapi.c
> @@ -316,3 +316,13 @@ HRESULT WINAPI DllGetActivationFactory(HSTRING classid, IActivationFactory **fac
>  
>      return REGDB_E_CLASSNOTREG;
>  }
> +
> +/***********************************************************************
> + *      RoSetErrorReportingFlags (combase.@)
> + */
> +HRESULT WINAPI RoSetErrorReportingFlags(UINT32 flags)
> +{
> +    FIXME("%d\n", flags);
> +    return S_OK;
> +}
> +

Note, you're adding a blank line at EOF here.

> diff --git a/include/roerrorapi.h b/include/roerrorapi.h
> index 454e1a6c2e9..b7d2322d1ae 100644
> --- a/include/roerrorapi.h
> +++ b/include/roerrorapi.h
> @@ -23,8 +23,18 @@
>  #include <restrictederrorinfo.h>
>  #include <rpc.h>
>  
> +typedef enum
> +{
> +    None,
> +    SuppressExceptions,
> +    ForceExceptions,
> +    UseSetErrorInfo,
> +    SuppressSetErrorInfo
> +} RoErrorReportingFlags;

This isn't what I have in my SDK.

I have the RO_ERROR_REPORTING_FLAGS enum.  The RoErrorReportingFlags
typedef in enclosed in namespaces - I'd leave that out for now.
Also note the values here are incorrect.

Huw.



More information about the wine-devel mailing list