[PATCH v3] combase: Add RoSetErrorReportingFlags stub
Alistair Leslie-Hughes
leslie_alistair at hotmail.com
Mon Feb 28 22:30:51 CST 2022
Hi Mohamad,
The ones I had where incorrect, so where removed. Nothing is going to
use the flags in the short term, so there is no need to have them right
away.
If you want to submit a patch for these flags, feel free as I only need
the stub.
Regards
Alistair
On 1/3/22 11:34, Mohamad Al-Jaf wrote:
> Hi Alistair,
>
> Shouldn't this include the flags? I added _RO_ERROR_REPORTING_FLAGS for
> copyright reasons.
>
> typedef enum _RO_ERROR_REPORTING_FLAGS {
> RO_ERROR_REPORTING_NONE = 0x00000000,
> RO_ERROR_REPORTING_SUPPRESSEXCEPTIONS = 0x00000001,
> RO_ERROR_REPORTING_FORCEEXCEPTIONS = 0x00000002,
> RO_ERROR_REPORTING_USESETERRORINFO = 0x00000004,
> RO_ERROR_REPORTING_SUPPRESSSETERRORINFO = 0x00000008,
> } RO_ERROR_REPORTING_FLAGS;
>
> cpp_quote("DEFINE_ENUM_FLAG_OPERATORS(RO_ERROR_REPORTING_FLAGS);")
>
> The semicolon at the end of the above line might not be needed.
>
> In the roerrorapi.h file there are 2 (+1 duplicate) enums for the error
> flags, one of which is enclosed in namespaces.
> I think Huw meant you should add the enum preceding the namespace.
> --
> Kind regards,
> Mohamad
More information about the wine-devel
mailing list