[PATCH] programs/cmd: expand commandline before starting parsing it

Alexandre Julliard julliard at winehq.org
Thu Jan 6 04:40:22 CST 2022


Eric Pouech <eric.pouech at gmail.com> writes:

> Hi Alexandre,
>
> this one will be harder to test... it only happens when cmd is not in batch mode (ie cmd reading directly from console APIs)
> all the tests in cmd/tests are done in batch mode (ie cmd reading from file APIs)
>
> since the expansion of variables is done currently done differently in batch mode vs non batch mode in cmd, adding a test to current infrastructure won't cover the use case
> (and it already works correctly in batch mode)
>
> it would require a new test harness inside cmd/tests to generate console input events instead of just passing the file handle
>
> I'll provide the tests UC for the other patches, but I'm rather in favor of applying this patch without a test case

All right. But if it's only in interactive mode I assume that it's not
fixing any real application, so it should wait until after code freeze.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list