[PATCH 4/8] d2d1/tests: Test coincident last/first vertex for both OPEN and CLOSED

Henri Verbeet hverbeet at gmail.com
Fri Jan 7 12:30:59 CST 2022


On Fri, 7 Jan 2022 at 09:00, Stefan Brüns <stefan.bruens at rwth-aachen.de> wrote:
>
> Provide two orientatations for both cases (END_OPEN/END_CLOSED) each.
>
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51139
> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
> ---
>  dlls/d2d1/tests/d2d1.c | 82 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 82 insertions(+)
>
Like the testbot, I'm getting some failures on Windows (Windows 7, AMD
Radeon HD 6310):

    d2d1.c:3897: Test failed: Got unexpected rectangle
{1.15500008e+002, 1.10000000e+002, 1.80000000e+002, 1.80000000e+002}.
    d2d1.c:3904: SIMPLIFY done
    d2d1.c:3897: Test failed: Got unexpected rectangle
{1.15500008e+002, 1.10000000e+002, 1.80000000e+002, 1.80000000e+002}.
    d2d1.c:3904: SIMPLIFY done
    0ba8:d2d1: 10482 tests executed (0 marked as todo, 2 failures), 0 skipped.

Increasing the tolerance on the compare_rect() call from 0 to 1 gets
rid of it for me.

> +    geometry_sink_init(&simplify_sink);
> +    hr = ID2D1PathGeometry_Simplify(geometry, D2D1_GEOMETRY_SIMPLIFICATION_OPTION_CUBICS_AND_LINES,
> +            NULL, 0.0f, &simplify_sink.ID2D1SimplifiedGeometrySink_iface);
> +    ok(SUCCEEDED(hr), "Failed to simplify geometry, hr %#x.\n", hr);
> +    trace("SIMPLIFY done\n");

That trace() looks like leftover debug code.



More information about the wine-devel mailing list